Skip to content

Show entities on area page#8980

Merged
bramkragten merged 2 commits intodevfrom
areas-list-entities
Apr 28, 2021
Merged

Show entities on area page#8980
bramkragten merged 2 commits intodevfrom
areas-list-entities

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 23, 2021

Breaking change

Proposed change

Show directly linked entities to an area on the area overview page.

Show the total count of entities (also those part of a device in that area)) in the area overview.

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment thread src/panels/config/areas/ha-config-area-page.ts Outdated
Comment thread src/panels/config/areas/ha-config-area-page.ts Outdated
Co-authored-by: Philip Allgaier <mail@spacegaier.de>
return {
devices: Array.from(devices.values()),
entities,
indirectEntities,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do anything with these?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still thinking about what to do with them 🤷 maybe a toggle to include them ? A new card ?

@bramkragten bramkragten merged commit 7962130 into dev Apr 28, 2021
@bramkragten bramkragten deleted the areas-list-entities branch April 28, 2021 15:01
@balloob balloob mentioned this pull request Apr 28, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants